Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache Player51 options state #99

Open
brimoor opened this issue Mar 10, 2020 · 3 comments
Open

Cache Player51 options state #99

brimoor opened this issue Mar 10, 2020 · 3 comments
Labels
needs-design Needs to be designed before it can be implemented properly

Comments

@brimoor
Copy link
Contributor

brimoor commented Mar 10, 2020

Currently I have to reconfigure my Player51 options each time I preview a video.

A more typical experience would be to cache my settings so that I get the same behavior each time I preview an output
@lethosor
Copy link
Contributor

Per-video? Per-page-load? Across page loads?

@lethosor lethosor transferred this issue from another repository Mar 10, 2020
@lethosor lethosor added the feature Work on a feature request label Mar 10, 2020
@brimoor
Copy link
Contributor Author

brimoor commented Mar 13, 2020

Conclusion: use local storage to store Player51 settings application-wide. Applies to all Player51 instances that are created, regardless of media type

@brimoor brimoor added release-issue and removed feature Work on a feature request release-issue labels Mar 13, 2020
@brimoor
Copy link
Contributor Author

brimoor commented Mar 19, 2020

Counterpoint: as I was just messing with Player51 settings, I found myself in a strange configuration of settings that was hard to get out of. I'm concerned that, if we do cache state, then entrylevel users may accidentally hide annotations and then complain that no annotations exist when previewing future videos.

So, let's not cache state for now.

@brimoor brimoor added the needs-design Needs to be designed before it can be implemented properly label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-design Needs to be designed before it can be implemented properly
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lethosor @brimoor