Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create support for a .vpt.yml to enable/disable actions and checks #304

Open
Flipez opened this issue Aug 14, 2021 · 4 comments
Open

Create support for a .vpt.yml to enable/disable actions and checks #304

Flipez opened this issue Aug 14, 2021 · 4 comments
Assignees
Labels
backend/poll-engine How we poll data and handle it enhancement New feature or request

Comments

@Flipez
Copy link
Member

Flipez commented Aug 14, 2021

As mentioned in #156 we currently have a list a repositories we ignore. And when we ignore them, we do it completely.

I propose a .vpt.yml where we can set the repository to be ignored completely and enable/disable different checks. I imagine it a bit similiar to the .rubocop.yml.

As a first iteration I would introduce the ignore flag and a simple flag for each check.

@bastelfreak WDYT?

@Flipez Flipez added enhancement New feature or request backend/poll-engine How we poll data and handle it labels Aug 14, 2021
@Flipez Flipez self-assigned this Aug 14, 2021
@bastelfreak
Copy link
Member

sounds like a good idea to me. we already have a .sync.yml to configure certain options for modulesync, maybe we can extend that with options for vpt.

@Flipez
Copy link
Member Author

Flipez commented Aug 14, 2021

I have no solid opinion and would stick to whatever you (or someone else) think would fit best in current workflows

@ekohl
Copy link
Member

ekohl commented Aug 30, 2021

One other thing to consider: you should ignore archived repos. I'm not sure if we have any today, but we at least don't manage all. For example, we've dropped puppet-wget. Have you considered using https://github.com/voxpupuli/modulesync_config/blob/master/managed_modules.yml (and possibly https://github.com/voxpupuli/pdksync_config/blob/master/managed_modules.yml) as a source?

@ekohl
Copy link
Member

ekohl commented Oct 1, 2021

I have another good reason this is a bad idea: it breaks modulesync:

Syncing 'puppet-example'
Overriding any local changes to repository in 'modules/voxpupuli/puppet-example'
Creating new branch new-rubocop from master
puppet-example: Error while rendering file: 'vpt'
bundler: failed to load command: msync (/home/ekohl/.gem/ruby/bin/msync)
/home/ekohl/.gem/ruby/gems/modulesync-2.2.0/lib/modulesync/renderer.rb:20:in `read': No such file or directory @ rb_sysopen - ./moduleroot/vpt.erb (Errno::ENOENT)
	from /home/ekohl/.gem/ruby/gems/modulesync-2.2.0/lib/modulesync/renderer.rb:20:in `build'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/poll-engine How we poll data and handle it enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants