Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes by Myron Pulier #35

Open
vpavlenko opened this issue Feb 20, 2018 · 0 comments
Open

Fixes by Myron Pulier #35

vpavlenko opened this issue Feb 20, 2018 · 0 comments

Comments

@vpavlenko
Copy link
Owner

3.4 should say "Given a positive integer".
4.3 should say "10 integers" not 10 numbers.
5.2 advises the student to use count. The simplest answer, counting the number of space characters, fails if there are multiple consecutive space characters in the input. The model solution is superior, but does not use count.
6.3 should say "For a given positive integer"... there is no solution if X < 1.
6.8 The model solution would be less confusing if line 4 was 'if a > maximum'; a student would wonder why >= is necessary (it isn't).
6.9 I had two issues with this. I was not sure where "first maximum" meant a relative (local) maximum (such as 2 in the sequence 2,1,3,2,3,0) or the first appearance of the absolute maximum value for the entire sequence (such as the 3 that follows the 1). Also, the example and the model solution use 1-based indexing, and that was not immediately clear. At first I assumed that "index" referred to the more-usual Python 0-based indexing convention.
6.B It was not immediately clear to me that "greater than their neighbors above" meant greater than their immediately preceding element. I was unsure about how many "neighbors above" to consider for each element. I know this seems silly in retrospect, but that was my reaction.
6.C Another probably silly problem. The statement that the sequence ends with 0 allows the possibility that 0 is part of the sequence, in which case (1,0) satisfies the guarantee of a sequence of at least two elements. Perhaps stating "not including the 0" would avoid any initial confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant