Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Change the theme there will be a bug! #736

Open
LukerSpringtree opened this issue Dec 11, 2024 · 1 comment
Open

[Bug]: Change the theme there will be a bug! #736

LukerSpringtree opened this issue Dec 11, 2024 · 1 comment
Labels
client scope: devtools client upstream Related to an upstream issue ux

Comments

@LukerSpringtree
Copy link
Contributor

See the video below:

2024-12-11.20.38.38.mov

If we change the theme by two different buttons, there is an error;
@LukerSpringtree LukerSpringtree mentioned this issue Dec 11, 2024
Closed
@LukerSpringtree LukerSpringtree changed the title [Bug]: Change theme has bug! [Bug]: Change the theme there will be a bug! Dec 11, 2024
@LukerSpringtree LukerSpringtree mentioned this issue Dec 13, 2024
Closed
@LukerSpringtree
Copy link
Contributor Author

I submitted a PR to vite-plugin-inspect. After understanding the background, my current plan is to add a hideDarkMode configuration option to vite-plugin-inspect. This way, the theme toggle button for the inspect module can be disabled in DevTools.
I believe this is the best solution for now.

@alexzhang1030 alexzhang1030 added client scope: devtools client upstream Related to an upstream issue ux labels Dec 20, 2024
LukerSpringtree pushed a commit to LukerSpringtree/devtools that referenced this issue Dec 22, 2024
fix: fix to vuejs#736 by update "vite-plugin-inspect"
fb77993
@LukerSpringtree LukerSpringtree mentioned this issue Dec 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client scope: devtools client upstream Related to an upstream issue ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(client): hide dark mode button of vite-plugin-inspect page LukerSpringtree/devtools
2 participants
@LukerSpringtree @alexzhang1030