Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We sometimes get errors from the GH API because of rate limits #40

Open
LinusBorg opened this issue Sep 18, 2019 · 2 comments
Open

We sometimes get errors from the GH API because of rate limits #40

LinusBorg opened this issue Sep 18, 2019 · 2 comments
Labels

Comments

@LinusBorg
Copy link
Member

LinusBorg commented Sep 18, 2019

e.g.: vuejs/vue-cli#4588

github API call fails :
api.github.com/repos/vuejs/vue-cli/releases?page=1&per_page=100 returns :

documentation_url: "https://developer.github.com/v3/#rate-limiting" message: "API rate limit exceeded for XXX.X.XXX.XXX. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)"

There's currently no error handling happening

@LinusBorg
Copy link
Member Author

LinusBorg commented Sep 18, 2019

  1. We need some error handling here:

const response = await fetch(`https://api.github.com/repos/${repo}/releases?page=${page}&per_page=100`)

  1. Assuming we can't easily/quickly get a higher rate limit from github some way, we should make sure that the issue helper works despite this, i.e. make the option field optional (...only if the versions request fails?).

  2. We could cache these version lists in localstorage so users that come back can fallback to an older list if the rate limit doesn't allow them to have an up-to-date one.

@meteorlxy
Copy link
Member

meteorlxy commented Sep 23, 2020

Always reaching rate limits in my company intranet, with a universal proxy....

@LinusBorg LinusBorg removed their assignment Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants