Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Remove header field in page data #1609

Open
Mister-Hope opened this issue Sep 30, 2024 · 4 comments · May be fixed by #1613
Open

[Feature request] Remove header field in page data #1609

Mister-Hope opened this issue Sep 30, 2024 · 4 comments · May be fixed by #1613
Labels
stale

Comments

@Mister-Hope
Copy link
Member

Clear and concise description of the problem

Now the downstream is no longer using header in page data (note: headers should still be on the page object).

Suggested solution

Since @vuepress/helper provides a way to get page headers from page contents, we 'd better remove it from page data to reduce client side data size.

Alternative

No response

Additional context

No response
@Mister-Hope Mister-Hope linked a pull request Oct 9, 2024 that will close this issue
feat(core)!: remove headers field from page data #1613
Open
@github-actions GitHub Actions
Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@github-actions github-actions bot added the stale label Oct 16, 2024
@Mister-Hope Mister-Hope removed the stale label Oct 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@github-actions github-actions bot added the stale label Nov 5, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
@Mister-Hope Mister-Hope reopened this Nov 13, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@Mister-Hope Mister-Hope removed the stale label Nov 21, 2024
@Mister-Hope Mister-Hope reopened this Nov 21, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2024

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

@github-actions github-actions bot added the stale label Dec 7, 2024
@Mister-Hope Mister-Hope removed the stale label Dec 8, 2024
@github-actions github-actions bot added the stale label Dec 24, 2024
@github-actions GitHub Actions
Copy link

This issue is marked as stale because it has not had recent activity. Issues marked with stale will be closed if they have no activity within 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core)!: remove headers field from page data vuepress/core
1 participant
@Mister-Hope