Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore]: Add option to rebuild VSF packages when running the project using Docker #238

Open
1 task done
kshalot opened this issue May 23, 2022 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@kshalot
Copy link
Collaborator

kshalot commented May 23, 2022

How the project can be improved?

Rollup provides basic hot-reloading when a file is changed (and it works in Docker thanks to using a volume) but it only reloads the theme package. When running VSF on the host machine, the user has to re-run either yarn dev or yarn build. This in theory should also work in the Docker setup since we are using a volume, so the compiled packages should be visible both to the host and to the container. There might be some nuance though - has to be investigated.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kshalot kshalot added the enhancement New feature or request label May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant