-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loosen restrictions on where remote resources can be referenced #1288
Comments
I'm not sure I fully understand the above.
This all seems a bit overly restrictive to me, I'm not sure I see the reason or what problem it is trying to solve. |
Also, I'm not familiar with the state of custom elements in EPUB, so this may not be so relevant, but these restrictions disallow any remote audio/video referenced from custom elements too. |
Ya, that's interesting now. They used to be not allowed because they were defined in separate W3C specs. But now that we're referencing the WHATWG document,
Ya, that gets kind of quirky. The reference will end up in an audio or video element, at least as I understand how custom elements work, but epubcheck won't know that because the html markup corresponding to the custom element is generated from code or a template at run time. |
The restrictions were undone, but it appears that epubcheck already restricts where remote resources can be referenced. Remote audio and video, at least, are only allowed from These restrictions need to be loosened to reflect the specification. |
It looks like fonts are also restricted. If I use a stylesheet link declaration or import rule for a Google font, I also get the message about the resource having to be placed in the OCF. And if I declare a font-face rule in an xhtml doc then epubcheck emits a warning that it couldn't find any remote resources in the file. |
Previously, EPUBCheck only allowed remote resources when they were used in elements we knew allowed remote resources (e.g. audio, video, font declaration). This commit improves this check by first checking that the resource media type allows remote resources, regardless of where the resource is used. Fix #1288
The following rules now apply:
audio
+source
elements and the MOaudio
elementvideo
+source
elements@font-face
rules,@import
rules, and the htmllink
elementSee w3c/epub-specs#1857
The text was updated successfully, but these errors were encountered: