-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider dfns curation process #789
Comments
Fixes w3c/webref#882 pending a more proper dfns curation process as envisioned in w3c/webref#789
Fixes w3c/webref#882 pending a more proper dfns curation process as envisioned in w3c/webref#789
If this issue one that would lead to the release of a I'm using the definitions for a project but they're not released separately so I have to use Anyway, it would be neat to be able to reference prose definitions! |
This issue is certainly a prerequisite to the possible release of a For other I'm asking because authoring tools typically want fresh data for their cross-reference database and would probably continue to use the repository contents directly even if we release a
Ah, I don't understand what's happening either, but I'll have a look. Maybe there's a simple fix (or maybe we don't need to have that script run as a prepare script). |
Yes, I would be fine with the data being a week or two late. Most of what we rely on is pretty foundational stuff that's not changing all the time. I tried to use the online data but there was too much latency and that caused intermittent failures.
To give some more details: if I |
The `prepare` script is run when the repository is installed. On top of creating issues when the repository is set as dependency in another project for some reason, as described in: #789 (comment) ... this also seems wrong because: 1. There is no guarantee that the curation will run without errors. A patch may no longer apply for instance. 2. Projects may want to depend on the raw data and may not need to run the curation and package preparation logic at all. This update replaces the "prepare" script with a "curate" one, explicitly called in the jobs that need it.
The `prepare` script runs automatically when the repository is installed. On top of creating issues when the repository is set as dependency in another project for some reason, as described in: #789 (comment) ... this also seems wrong because: 1. There is no guarantee that the curation will run without errors. A patch may no longer apply for instance. 2. Projects may want to depend on the raw data and may not need to run the curation and package preparation logic at all. This update replaces the "prepare" script with a "curate" one, explicitly called in the jobs that need it. Other projects that depend on the webref repository directly and on curated data also need to update to call npm run curate explicitly.
I don't know what happens, but I don't think the prepare script in webref should run automatically on installs in any case, for reasons mentioned in #914. So I dropped it as well (or rather renamed it to "curate"). A |
Via w3c/reffy#1110
We don't have a curation mechanism in place right now for dfns because the intent was to propagate updates as soon as new crawl results are available to cross-references databases, and CSS/IDL data curation requires manual fixing on a regular basis. To prevent stalls, we'd need a way to have dfns curation continue even when CSS/IDL curation fails. That could perhaps be achieved simply by running the curation separately in yet another branch.
Dfns curation would also be useful to detect and prevent situations where crawl drops a large number of definitions by mistake, e.g. because the crawl succeeds and yet the crawled spec is temporarily broken to the point where no dfns can be extracted (something similar happened in Shepherd/Bikeshed recently for instance).
This would also allow us to create patches if that seems needed. We managed to survive without that for dfns until now though.
The text was updated successfully, but these errors were encountered: