Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: go-waku logs zone-sensitive time #1191

Closed
igor-sirotin opened this issue Aug 12, 2024 · 3 comments · Fixed by #1192
Closed

bug: go-waku logs zone-sensitive time #1191

igor-sirotin opened this issue Aug 12, 2024 · 3 comments · Fixed by #1192
Assignees

Comments

@igor-sirotin
Copy link
Collaborator

Problem

Status user reported there're some logs that use local timezone, which exposes user's location.
I fixed a few in status-go, but there're some in go-waku as well:

zap.Time("currentTime", now), zap.Time("until", tv.nextTry))
zap.Time("currentTime", now), zap.Time("nextTry", tv.nextTry))
logging.HostID("peerID", peerID), zap.Time("until", cachedPeer.nextTry))

Solution

When logging, we should always convert time to UTC.

@igor-sirotin
Copy link
Collaborator Author

cc @richard-ramos @chaitanyaprem

@chaitanyaprem
Copy link
Collaborator

@igor-sirotin included a fix in #1192 .

If we need this as part of current release, then i will create a PR for release branch cherry-picking this commit.

@igor-sirotin
Copy link
Collaborator Author

igor-sirotin commented Aug 13, 2024

@chaitanyaprem thanks for the fix!

Though it's a simple fix, I don't like to harass cherry-picking that much.
And I didn't cherry-pick this fix as well: status-im/status-go#5672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants