Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format ns-qualified maps? #176

Open
vemv opened this issue Sep 23, 2019 · 2 comments
Open

Format ns-qualified maps? #176

vemv opened this issue Sep 23, 2019 · 2 comments

Comments

@vemv
Copy link
Contributor

vemv commented Sep 23, 2019

Hi there,

cljfmt doesn't appear to format ns-qualified maps:

cljfmt.test-util.common=> (reformat-string "#:foo.bar  {:owner-type 1}" {})
"#:foo.bar  {:owner-type 1}"
cljfmt.test-util.common=> (reformat-string "#:foo.bar {:owner-type 1}" {})
"#:foo.bar {:owner-type 1}"
cljfmt.test-util.common=> (reformat-string "#:foo.bar{:owner-type 1}" {})
"#:foo.bar{:owner-type 1}"

...this has the specific impact (at least as my coworker reports) that Cursive's Parinfer can stop working properly if there's any whitepsace between the qualifer and the map.

Is this something you have tried working on at some point? (Asking because it might be hard to fix)

Thanks - V

@weavejester
Copy link
Owner

If someone wants to send me a PR to add a feature then I'll certainly review and (eventually!) merge it in. But I have to many other projects to devote much time to cljfmt myself.

@lread
Copy link
Contributor

lread commented Mar 15, 2021

@vemv, I think I might have started on this a long while ago but abandoned my effort. I can take up the cause again if/after we upgrade to rewrite-clj v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants