-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do you want the project.clj
file to be included by default for lein projects?
#279
Comments
This seems a reasonable change. |
jacobemcken
added a commit
to jacobemcken/cljfmt
that referenced
this issue
Dec 10, 2022
Since the file project.clj is specific to Leiningen projects it seem like a good default. Resolves: weavejester#279
jacobemcken
added a commit
to jacobemcken/cljfmt
that referenced
this issue
Dec 29, 2022
Since the file project.clj is specific to Leiningen projects it seem like a good default. Fixes: weavejester#279
jacobemcken
added a commit
to jacobemcken/cljfmt
that referenced
this issue
Jan 18, 2023
Since the file project.clj is specific to Leiningen projects it seem like a good default. Fixes: weavejester#279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am seeing this:
cljfmt/cljfmt/src/cljfmt/main.clj
Line 169 in 1003c67
But the
project.clj
file is ignored when runninglein cljfmt check
(empty configuration), unless I specifically specify it (lein cljfmt check project.clj
).I've narrowed it down to
(seq paths)
never being empty when the paths come from the Leiningen plugin:cljfmt/cljfmt/src/cljfmt/main.clj
Line 216 in 1003c67
Do you want a PR changing
lein-cljfmt
to always include theproject.clj
file?I was thinking that it could look something like (changing
lein-cljfmt/src/leiningen/cljfmt.clj
):It seems to be a good fit since the project file is lein specific anyway.
The text was updated successfully, but these errors were encountered: