-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include project.clj by default for lein plugin #280
base: master
Are you sure you want to change the base?
Include project.clj by default for lein plugin #280
Conversation
Thanks for the PR! Why did you choose Also, can you change the commit message to:
I think the "by default" is misleading, because in this case it can't be changed. If this turns out to be an issue, we can add in an option to allow it to be omitted. Have you tested to ensure that this plugin change works with both |
59ddbdd
to
5801e3b
Compare
My lack of knowledge.
Either I don't understand meaning of your comment or I disagree. As soon as you provide an alternative configuration in the ...
:cljfmt {:paths ["src"]}
... The I had only tested with |
I don't think this is correct: leiningen.cljfmt=> (format-paths {:source-paths ["src"], :test-paths ["test"], :cljfmt {:paths ["src"]}})
("project.clj" #object[java.io.File 0x2ac11170 "src"]) You cons the string "project.clj" onto the list regardless of what is set in |
Since the file project.clj is specific to Leiningen projects it seem like a good default. Fixes: weavejester#279
5801e3b
to
7ada90e
Compare
The reason why it worked as a string regardless, is that both cljfmt/cljfmt/src/cljfmt/main.clj Lines 33 to 34 in a4dd48e
Thankfully, layering I've moved "extending |
Since the file project.clj is specific to Leiningen projects it seem like a good default.
Resolves: #279