You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We've come across some sites where the scheme's are capitalised, as wombat expects these to be lower cased they are not re-written.
I'm happy to put in a PR for this but before doing the work thought I should ask whether you'd want wombat to handle scheme's case insensitively first?
Scheme names consist of a sequence of characters beginning with a
letter and followed by any combination of letters, digits, plus
("+"), period ("."), or hyphen ("-"). Although schemes are case-
insensitive, the canonical form is lowercase and documents that
specify schemes must do so with lowercase letters. An implementation
should accept uppercase letters as equivalent to lowercase in scheme
names (e.g., allow "HTTP" as well as "http") for the sake of
robustness but should only produce lowercase scheme names for
consistency.
If you'd like support for this would you prefer for it to be added via a regex patten match or via explicitly adding the additional options?
Thanks for filing this! Probably the simplest option is to add a .toLowerCase() when doing checks for VALID_PREFIXES, HTTP_PREFIX or HTTPS_PREFIX. If you can submit a PR for that, would be happy to accept!
We've come across some sites where the scheme's are capitalised, as wombat expects these to be lower cased they are not re-written.
I'm happy to put in a PR for this but before doing the work thought I should ask whether you'd want wombat to handle scheme's case insensitively first?
From RFC 3986:
If you'd like support for this would you prefer for it to be added via a regex patten match or via explicitly adding the additional options?
wombat/src/wombat.js
Line 36 in 20596ca
The text was updated successfully, but these errors were encountered: