Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration file support for Nuget feeds and packages #34

Open
mikoskinen opened this issue Oct 14, 2020 · 1 comment · May be fixed by #41
Open

Add configuration file support for Nuget feeds and packages #34

mikoskinen opened this issue Oct 14, 2020 · 1 comment · May be fixed by #41
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mikoskinen
Copy link
Contributor

Currently configuration file supports the configuration of Assembly and Folder catalogs.

Add support for configuring feed and package catalogs.

@mikoskinen mikoskinen added the enhancement New feature or request label Oct 14, 2020
@mikoskinen mikoskinen added this to the v1.2 milestone Oct 14, 2020
@mikoskinen
Copy link
Contributor Author

Currently the IConfiguration support is provided using the following two classes:

FolderCatalogConfigurationConverter
AssemblyCatalogConfigurationCoverter

When implementing this feature we should add one for nuget feeds and one for nuget packages. These should be added into Weikio.PluginFramework.Catalogs.Nuget.

The converters must be registered into the DI before they can be used:

        services.AddTransient(typeof(IConfigurationToCatalogConverter), typeof(NugetFeedCatalogConfigurationConverter));
        services.AddTransient(typeof(IConfigurationToCatalogConverter), typeof(NugetPackageCatalogConfigurationCoverter));

@mikkou-adafy mikkou-adafy linked a pull request Jan 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants