Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new category defaults Categories settings to last page #532

Open
cinadia opened this issue May 23, 2024 · 1 comment · May be fixed by #564
Open

Adding a new category defaults Categories settings to last page #532

cinadia opened this issue May 23, 2024 · 1 comment · May be fixed by #564
Assignees
Labels
bug Something isn't working

Comments

@cinadia
Copy link
Contributor

cinadia commented May 23, 2024

Describe the bug
If a user adds a new Category in the "Categories and Phrases" section of the Settings, each time the user navigates back to the "Categories and Phrases" section, the page will default to the page where the Category was originally added*. This behaviour can only be undone by killing and restarting the app (i.e. removing the newly added Categories does not reverse the behaviour).

*(When Categories are hidden and the user adds a new Category, the new Category will be placed before all the hidden categories. In this case, each time the user navigates back to the "Categories and Phrases" section, the page will default back to the page where the new Category was originally placed.)

To Reproduce

  1. Navigate to Settings > Categories and Phrases
  2. Add a new Category
  3. Exit Settings
  4. Navigate back to Settings > Categories and Phrases
  5. The page will be the last page instead of the first (observe the "Page x of x" at the bottom)
  6. Kill and restart the app to remove the behaviour

Expected behavior
The Categories and Phrases page in Settings should only scroll to [the page that the new Category was added to] immediately after the new Category is created. When a user navigates away from the "Categories and Phrases" page and then navigates back after adding a new Category, they should land on page 1.

Actual Behavior
The Categories and Phrases page jumps to the page that the new Category was added to every single time.

Smartphone (please complete the followng information):

  • Device: Pixel 4
  • OS: Android 12
@cinadia cinadia added the bug Something isn't working label May 23, 2024
@cinadia cinadia self-assigned this May 27, 2024
@github-project-automation github-project-automation bot moved this to Ready to select in Vocable-Android May 29, 2024
@cinadia cinadia linked a pull request May 29, 2024 that will close this issue
2 tasks
@cinadia cinadia removed a link to a pull request May 29, 2024
2 tasks
@PaulKlauser
Copy link
Collaborator

Very thorough writeup, love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In progress
2 participants