Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tutorial For Doubly linked list #117

Closed
wants to merge 2 commits into from
Closed

Added Tutorial For Doubly linked list #117

wants to merge 2 commits into from

Conversation

i-dipanshu
Copy link

Fixes #60
Signed off by: Dipanshu

wingkwong
wingkwong requested changes Oct 1, 2022
View reviewed changes
Copy link
Owner

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Code format is bad. (e.g. indentation)
  2. Don't rely on GFG tutorials. I found most of them are overcomplicated and some TCs are actually incorrect.
  3. As a reader, I can't see how I can use it in LC problems. Walk through some LC problems and try to map what you show.

@wingkwong wingkwong added the Status: Pending for Changes The PR is reviewed with some changes requested. Waiting for contributors' actions. label Oct 9, 2022
@wingkwong
Copy link
Owner

Any updates?

@i-dipanshu
Copy link
Author

i-dipanshu commented Oct 13, 2022 •
edited
Loading

Sorry For the delay
been just busy with other things
Will make the requested change soon

@wingkwong
Copy link
Owner

any update?

@wingkwong
Copy link
Owner

Closing due to inactivity.

@wingkwong wingkwong closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wingkwong wingkwong wingkwong requested changes

Assignees
No one assigned
Labels
Status: Pending for Changes The PR is reviewed with some changes requested. Waiting for contributors' actions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tutorial Writeup - Doubly Linked List
2 participants
@i-dipanshu @wingkwong