Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend anchors have extra styling in firefox #1247

Open
nmiyazaki-chapleau opened this issue Nov 4, 2024 · 3 comments
Open

Backend anchors have extra styling in firefox #1247

nmiyazaki-chapleau opened this issue Nov 4, 2024 · 3 comments
Labels
help wanted Issues/PRs that are good candidates for new contributors to look into

Comments

@nmiyazaki-chapleau
Copy link

nmiyazaki-chapleau commented Nov 4, 2024

Winter CMS Build

1.2

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

Firefox adds a blue outline to anchor elements on :focus (which honestly looks horrible) and interferes with the look & feel of WinterCMS.
Some example of problematic places include sections with tabs - on click, which makes the element focused, it add a small blue outline on the left and right side of the element.
Example in the CMS tabs:
Image
Example in the underlying section:
Image

Steps to replicate

  1. Open firefox
  2. Go to backend
  3. Click on anything that is an anchor

Workaround

Can be fixed using a:focus, a:focus-visible { outline: none; }. However, I do not know if this is intended behavior.

@damsfx
Copy link
Contributor

damsfx commented Nov 4, 2024

Same for form primary tabs
Image

@LukeTowers
Copy link
Member

So long as the focused element has some form of styling to distinguish it for usability I'd be more than happy to merge any PR suggested. Let me know if you need help submitting one!

@LukeTowers LukeTowers added the help wanted Issues/PRs that are good candidates for new contributors to look into label Nov 5, 2024
@bennothommo
Copy link
Member

I remember this being added back in the October days. It's horrific. I would very much like a more elegant solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues/PRs that are good candidates for new contributors to look into
Projects
None yet
Development

No branches or pull requests

4 participants