Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style to headings #34

Open
damsfx opened this issue May 16, 2023 · 5 comments
Open

Add style to headings #34

damsfx opened this issue May 16, 2023 · 5 comments

Comments

@damsfx
Copy link
Contributor

damsfx commented May 16, 2023

As Tailwind unstyled headings (see: Headings are unstyled ), it make a significant difference between standard and tailwind backend UIs.

Standart Winter backend UI
image

This plugin
image

Wouldn't it be possible to add some substance to the titles, or the plugin devs have to add their owns styles ?

@LukeTowers
Copy link
Member

I'm fine with any PRs you want to make so long as they have before / after screenshots for me to review :)

@damsfx
Copy link
Contributor Author

damsfx commented May 17, 2023

I'm fine with any PRs you want to make so long as they have before / after screenshots for me to review :)

Not a problem.

But before to impose a style for the headings, I would like to have some precisions.
According to you, is it the responsibility of this plugin to provide styles for the headings or is it up to the developer of the plugin that uses the headings in its controller to define its own styles?

I see for example that when we consult the readme of a plugin (/backend/system/updates/details/winter-blog), the headings are styled by the Updates.php controller

https://github.com/wintercms/winter/blob/95619bf30a905753e8456385c9814792978f190a/modules/system/assets/css/updates/details.css#L7-L18

@LukeTowers
Copy link
Member

It is the responsibility of this plugin to provide a fully styled backend skin, it's safe to assume that if the default skin styles something then this plugin should also style said element, albeit with more of a modern look.

@damsfx
Copy link
Contributor Author

damsfx commented May 17, 2023

@LukeTowers That answer my question.
So no need to style the headings from the Tailwinf-UI plugin.

@LukeTowers
Copy link
Member

Well this plugin should at the very least provide the same visual distinction between titles and regular text that the default backend skin does, and I'm fine if we want to go above and beyond to make the backend feel more modern and consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants