Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top menu nav color and shadow #5

Open
damsfx opened this issue Jul 20, 2022 · 5 comments
Open

Top menu nav color and shadow #5

damsfx opened this issue Jul 20, 2022 · 5 comments

Comments

@damsfx
Copy link
Contributor

damsfx commented Jul 20, 2022

<?php if ($menuLocation === 'top'): ?>
bg-gray-800
<?php else: ?>
bg-gray-800 md:bg-white md:shadow
<?php endif; ?>

1 - Why switch to a white background?

I find the bar not contrasting enough in the overall interface.

I would prefer even a light color:
image

2 - For me, the shadow is not visible.

For it to be visible, a relative position and z-index must be added to the .layout-topmenu element.
Also I would have chosen a wider shadow (shadow-md).

Actual - invisible shadow:
image

With shadow visible :
image

With shadow-md visible :
image

I would be pleased to hear your thoughts on this.

@LukeTowers
Copy link
Member

@damsfx I would agree with those assessments. As far as colour goes I actually want this plugin to have a light theme and a dark theme with the colour matching between the top bar and the side bar for each version, but for now fixing the shadow to show (the size of it seems fine to me without further changes for now).

@mjauvin
Copy link
Member

mjauvin commented Jul 22, 2022

I personally think the top bar serves no actual purpose when the menu is on the left. It breaks the otherwise great look of the backend layout.

@LukeTowers
Copy link
Member

@mjauvin it doesn't serve much of a purpose yet but it will. The plan is to have a backend-wide search bar in the top left of it as well as a few more additions on the right to the quick actions menu like a quick create button and notification management

@bennothommo
Copy link
Member

I'm having a play around with this skin for a client at the moment. I can see the rationale for that user bar based on what @LukeTowers wants to do with it going forward, but to offer a counterpoint, the reason that some people prefer side menus (including myself) is the maximise the amount of vertical space for the actual page or function being used, and to take advantage of the amount of width modern monitors have.

Unfortunately, the user bar negates that benefit because it takes up the same amount of space as it would having the main nav at the top, whilst also decreasing the amount of space horizontally too.

See the following:

Top nav
Top Nav Example

Side nav
Side Nav Example

Effectively, the usable viewport for the Backend itself is shrunk a little bit if someone uses the side nav option.

Ideally, it would be nice to have the user functions condensed into the side nav, but I can understand if that might be difficult.

@LukeTowers
Copy link
Member

What I'd like to have is for the side menu layout to have the ability to collapse down to the icon only mode with the press of a button like a mobile menu and then re-show the full size version when hovering over it or clicking the button again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants