Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current playground is not enough to contribute into playable #131

Open
rudnitskih opened this issue Sep 18, 2019 · 7 comments
Open

The current playground is not enough to contribute into playable #131

rudnitskih opened this issue Sep 18, 2019 · 7 comments
Assignees

Comments

@rudnitskih
Copy link
Contributor

During working on RTL feature we found only one way how to test playble in different configurations is change something in develop.ts file. This approach is annouying because is diffuclt to understand all possible configurations for library and make some changes.

I propose to describe all options in playground page.

@rudnitskih
Copy link
Contributor Author

PR - #134

@rudnitskih
Copy link
Contributor Author

TODOs:

  • Better integration with oki-doc (make storybook as subpage of docs site, not external links)
  • Think about which knobs should be in the playground
  • Better code architecture for Story

@rudnitskih
Copy link
Contributor Author

@rudnitskih
Copy link
Contributor Author

rudnitskih commented Sep 20, 2019

Unfortunately, after the following npm i some issue with webpack which I don't know how to fix quickly:

image

Will try to take a look on next week.

@rudnitskih
Copy link
Contributor Author

@Dariia Did you have any progress with this on Friday?

@mykolavlasov
Copy link
Contributor

@BrooklynKing
Copy link
Collaborator

I fixed this problem with new API for css-loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants