Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Redundant config data due to each implementation storing a copy #10

Open
met4000 opened this issue Dec 12, 2019 · 0 comments
Open

Redundant config data due to each implementation storing a copy #10

met4000 opened this issue Dec 12, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@met4000
Copy link
Member

met4000 commented Dec 12, 2019

private:
DeployableDeviceConfig _config;

As the config isn't stored as a pointer (and is private), all implementations of DeployableDevice have to store an additional copy of their own config, which contains redundant data also stored in DeployableDevice::config - much more memory is used than needed, especially if the config contains non-pointer types complex types.

This problem isn't limited to just DeployableDevice (I used it as an example), but overall it shouldn't take too long to fix and is also backwards compatible.

@met4000 met4000 added the bug Something isn't working label Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant