Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netsplits are not properly hidden when J/P/Q is toggled on #31

Open
phuzion opened this issue Aug 28, 2020 · 0 comments
Open

Netsplits are not properly hidden when J/P/Q is toggled on #31

phuzion opened this issue Aug 28, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@phuzion
Copy link

phuzion commented Aug 28, 2020

When the "Hide J/P/Q" feature is turned on, netsplits are not properly hidden. Back in July, this was discovered by tmbg in #woboquassel on IRC, but apparently an issue was never raised here.

As @guruz mentioned, it's likely just a couple of messagetypes that need to be added to the logic of hiding JPQs. I believe I have found where these messagetypes need to go.

https://github.com/woboq/iquassel/blob/master/quassel-for-ios/quassel-for-ios/vcs/BufferViewController.m#L538-L544

It should just be a matter of adding the following to the code after line 541:

|| (message.messageType & MessageTypeNetsplitQuit))
|| (message.messageType & MessageTypeNetsplitJoin))

@guruz guruz added the bug Something isn't working label Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants