Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCTP: Per-message burn limit warning #722

Open
kev1n-peters opened this issue Oct 22, 2024 · 2 comments
Open

CCTP: Per-message burn limit warning #722

kev1n-peters opened this issue Oct 22, 2024 · 2 comments

Comments

@kev1n-peters
Copy link
Collaborator

kev1n-peters commented Oct 22, 2024 •
edited
Loading

The CCTP protocol implementations should fetch the per-message burn limit in the quote method and add a warning to the return value if the transfer amount exceeds the limit.

See: https://developers.circle.com/stablecoins/limits

Contract method on Ethereum for example (USDC token input address: 0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48) https://etherscan.io/address/0xc4922d64a24675e16e1586e3e3aa56c06fabe907#readContract#F1
@Wesleyleung
Copy link

Wesleyleung commented Oct 22, 2024 •
edited
Loading

We could use the same warning message we use for bad quotes and manual txns to show this message. In addition, we should disable the "review transaction" button if the user selected this route.

1b - Txn - Auto Loading Routes (25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wesleyleung @kev1n-peters and others