Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize missing thumbnail sometimes isnot working for custom size #894

Open
Mai-Saad opened this issue Aug 14, 2024 · 0 comments
Open

Optimize missing thumbnail sometimes isnot working for custom size #894

Mai-Saad opened this issue Aug 14, 2024 · 0 comments
Labels
priority: medium Issues which are important, but no one will go out of business. severity: moderate type: bug

Comments

@Mai-Saad
Copy link

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version =>2.2.3
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When a custom thumbnail is set using the following filter in the active theme, when clicking optimize 1 missing thumbnail is not working with some images

add_action( 'after_setup_theme', function() {
add_image_size( '200', 200, 200 );
} );

To Reproduce
Steps to reproduce the behavior:

  1. Use the filter above
  2. Upload an image like attached
  3. Click optimize 1 missing thumbnail link in the media library list for the optimized image
  4. Nothing happens and the link is still there
    360_F_289306269_rJ04x9o9Dbv8zHcImf9kRZA08bVCimIP
    tablet_11971515051363428

Expected behavior
The link 'optimize 1 missing thumbnail' gets hidden and optimize the needed thumbnail or show notice if something is wrong (please refer to @wp-media/product to confirm the expected)

Screenshots
Screenshot from 2024-08-14 17-01-26

Additional context

  • If this image is used instead, clicking optimize 1 thumbnail will be hidden once clicked and optimized images will be updated

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

@Mai-Saad Mai-Saad added type: bug priority: medium Issues which are important, but no one will go out of business. severity: moderate labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Issues which are important, but no one will go out of business. severity: moderate type: bug
Projects
None yet
Development

No branches or pull requests

1 participant