Scope a solution ✅

In WPMedia\PluginFamily\Controller

• Create a new method that will hold plugins with custom download urls and accept plugin slug as argument, so the plugin slug would be the key and the custom urls as value, we will return the download url with the matching key passed as argument to the method.

  • To append the correct plugin slug to the end of the url, we will create a new trait that handles this logic so we can share it with WPMedia\PluginFamily\Model::PluginFamily since we currently pass this as an argument. This trait will have a method that returns the main plugin slug where the package is installed. For rank math the main plugin slug is appended to the end of the url, for another plugin it could be somewhere in the middle of the url, for this I suggest we use a generic placeholder in the links, so at the end we can just replace every occurrence of this placeholder with the main plugin slug.

• Use this new method in WPMedia\PluginFamily\Controller::get_download_url to return early if there's a match for a plugin with custom download url.

Update tests.

Estimate the effort ✅

[XS]

Would this be limited to just Imagify & WP Rocket? @MathieuLamiot

@jeawhanlee Thanks!

Would this be limited to just Imagify & WP Rocket?

Those are the only use-cases we have currently, but this could be extended and there are no specific reasons to restrict. Ideally, plugin-family would just add the plugin slug in the link rankmath.com/download/plugin-family/_plugin_slug_ so that we have future compatibility with whichever plugin uses plugin-family

LGTM

@MathieuLamiot Do we need to trigger download, install and activate using the custom url with one-click?

Yes, the behavior of the button must be completely the same as currently, just using a different place to download the plugin.

Ok Thanks, the grooming above does not satisfy this, we'll need to update it.

Moving this back to Grooming in Progress then. Can you look into it? Thanks 🙏

Update from Mladen at RankMath: the links will be downloads/plugin-family instead of download/plugin-family.
I am updating the GH issue.

The links are already working.

Grooming has been updated to fit AC

LGTM

@jeawhanlee @piotrbak It woudl be great if this update is:

• included in WP Rocket 3.17.4
• NOT included in Imagify 2.2.4

I guess we can just avoid updating the plugin-family version in Imagify for now. Thanks 🙏