Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin conflict w/ Query Monitor #63

Open
lkraav opened this issue Sep 29, 2018 · 4 comments
Open

Plugin conflict w/ Query Monitor #63

lkraav opened this issue Sep 29, 2018 · 4 comments

Comments

@lkraav
Copy link

lkraav commented Sep 29, 2018

There's a clear few second delay for QM finishing loading just by having Rocket Lazy Load active.

If you enable a large data set panel like SAVEQUERIES true, delay will be tens of seconds, if not for all intents and purposes "infinite" (depending on how high the query count is).

Hypothesis: something within post-page-load JS routines probably collide.

Symptom: visible parts of the page finish loading, then it comes time for QM to render its admin panel, but this part never finishes, and browser tab starts spinning CPU at 100%.

Cross-repo issue at johnbillion/query-monitor#350

Can you guys help figure this out? We could really use having both plugins active.

@lkraav
Copy link
Author

lkraav commented Nov 14, 2018

I have discovered additional info, that maybe invalidates above hypothesis.

Our comments table is ballooning due to how some plugins store their metadata, and it turns out Admin Bar "Comments" menu item scans comments table on every request.

This becomes a massive performance bottleneck at hundreds of thousands of comments table rows, so I unhooked those menu items (source: https://gist.github.com/mattclements/10a997775894c7a0eba1)

I will also take a closer look at SAVEQUERIES next. It's likely this is not a JS topic at all.

@lkraav
Copy link
Author

lkraav commented Dec 11, 2018

Update: there's definitely something still going on. Investigation continues.

@lkraav
Copy link
Author

lkraav commented Jan 10, 2019

2.0.2: things seem better here. Will report back in about 2 more weeks, so the experience sample size becomes adequate.

@lkraav
Copy link
Author

lkraav commented Feb 1, 2019

rocket-lazy-load-2.3.0.2
query-monitor-3.2.2

This is now confirmed to still be a problem, with plugins at their latest versions, but surprisingly only on Chrome.

All other performance issue vectors are confirmed to have been eliminated.

Firefox-64+ seems to somehow manage to avoid this issue.

PS 2.3.0.2 is missing its github tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants