You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently, we aren't doing the check for preload markup for all the templates at lcp which results in hidden 404 after markup is applied and sometimes fatal error
Describe the solution you'd like
For all templates, we need:
Before all => visit all lcp templates so lcp/atf is created
Given cache is cleared
When template x is visited
And hard refresh the page // this step as sometimes markup changes when we have timestamp cache at the page due to a special char handle
then no error in debug.log
And no console error
Additional context
Possible enhancements:
we can add as well that no visual regression or it will take much time
we can check the markup is as expected or if it's already at integration tests (for all templates) then we can skip here
we can check that fetchpriority='high' is added to image tag (this exists in some templates so may be better be other test) ==> as per LCP test for checking fetchpriority fails consistently #98 it's just now for lcp_regular_img_template so we can add on that other templates containing img tag either in picture or not
Is your feature request related to a problem? Please describe.
Currently, we aren't doing the check for preload markup for all the templates at lcp which results in hidden 404 after markup is applied and sometimes fatal error
Describe the solution you'd like
For all templates, we need:
Before all => visit all lcp templates so lcp/atf is created
Given cache is cleared
When template x is visited
And hard refresh the page // this step as sometimes markup changes when we have timestamp cache at the page due to a special char handle
then no error in debug.log
And no console error
Additional context
Possible enhancements:
@MathieuLamiot @jeawhanlee what do you think?
The text was updated successfully, but these errors were encountered: