Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolate VR Tests to be generic for all WPR features #140

Open
jeawhanlee opened this issue Sep 13, 2024 · 1 comment
Open

Isolate VR Tests to be generic for all WPR features #140

jeawhanlee opened this issue Sep 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@jeawhanlee
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We need to isolate VR test to run for any WPR feature we want.
We currently have a dedicated test for VR but we need to update it to be compatible with any WPR feature as desired i.e we need to be able to run it against any WPR feature we enable.

Describe the solution you'd like
We need to update the current VR test to accommodate this new change by parsing an additional argument to the command which is the feature to be enabled. i.e npm run test:vr --f=feature and we can use this to enable it.

Scenario: NO visual regression when feature 'x' is enabled on live template
Given: WPR is activated
And: feature 'x' is enabled
When: open VR URL
And: scroll to the end of page
Then: no VR compared to nowprocket URL

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@jeawhanlee jeawhanlee added the enhancement New feature or request label Sep 13, 2024
@jeawhanlee jeawhanlee assigned jeawhanlee and unassigned jeawhanlee Sep 13, 2024
@MathieuLamiot
Copy link
Contributor

Blocked until we have all-green test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants