Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Google Fonts option prevents font effects from being applied in the UI #7148

Open
hanna-meda opened this issue Nov 28, 2024 · 0 comments
Labels
module: google fonts priority: medium Issues which are important, but no one will go out of business. severity: moderate Feature isn't working as expected but has work around to get same value

Comments

@hanna-meda
Copy link

Describe the bug
While Google Fonts Optimization option is enabled, font effects specified in the Google Fonts API are not applied in the UI.

To Reproduce
Steps to reproduce the behavior:

  1. Activate WPR version 3.9.5 or higher.
  2. Visit a page using Google Fonts API that includes font effects, e.g.:
    https://fonts.googleapis.com/css2?family=Roboto|Lobster|Tangerine|Montserrat&effect=fire|fire-animation|neon|3d|shadow-multiple|emboss|anaglyph
  3. Observe that the fonts load, but their effects (e.g., fire, neon, 3D) are not applied.

Notes:

  1. Font effects are applied correctly on ?nowprocket visit of the page or when Disable Google Font Optimization helper plugin is activated.
  2. Font effects work as expected in WPR version 3.8.8 or below.

Expected behavior
Font effects should function as intended and not be blocked or altered by the “Combine Google Fonts” optimization option.

Screenshots
Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@hanna-meda hanna-meda added module: google fonts type: bug Indicates an unexpected problem or unintended behavior priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value priority: high Issues which should be resolved as quickly as possible and removed priority: low Issues that can wait type: bug Indicates an unexpected problem or unintended behavior labels Nov 28, 2024
@piotrbak piotrbak added priority: medium Issues which are important, but no one will go out of business. and removed priority: high Issues which should be resolved as quickly as possible labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: google fonts priority: medium Issues which are important, but no one will go out of business. severity: moderate Feature isn't working as expected but has work around to get same value
Projects
None yet
Development

No branches or pull requests

2 participants