Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #7181 fonts data collection #7199

Open
wants to merge 10 commits into
base: feature/host-google-fonts
Choose a base branch
from
Open

Closes #7181 fonts data collection #7199

wants to merge 10 commits into from
+321 −3

Conversation

remyperona
Copy link
Contributor

@remyperona remyperona commented Dec 19, 2024 •
edited
Loading

Description

Fixes #7181

Collect fonts data weekly

Type of change

Detailed scenario

With self-host google fonts and analytics enabled, fonts data should be collected and sent to mixpanel.

data collected is stored in a transient rocket_fonts_data_collection for a week.

Technical description

Documentation

If the options are enabled, and the transient is not yet set, with recursively look into the cache/fonts/blog_id/google-fonts/fonts/ folder to count all fonts and and the total size.

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

Additional Checks

  • In the case of complex code, I wrote comments to explain it.

@remyperona remyperona added the type: sub-task Indicates the issue is a sub-task linked to an epics card label Dec 19, 2024
@remyperona remyperona added this to the 3.18 milestone Dec 19, 2024
@remyperona remyperona self-assigned this Dec 19, 2024
@codacy-production Codacy Production
Copy link

codacy-production bot commented Dec 19, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.05% (target: -0.10%) ✅ 72.22% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a60bcda) 38667 17085 44.18%
Head commit (a8a6048) 38713 (+46) 17123 (+38) 44.23% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#7199) 54 39 72.22%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@remyperona remyperona linked an issue Dec 19, 2024 that may be closed by this pull request
3.18 - Data collection related to disk usage #7181
Open
@remyperona remyperona requested a review from a team December 20, 2024 20:19
@remyperona remyperona marked this pull request as ready for review December 20, 2024 20:19
@Mai-Saad
Copy link
Contributor

For testing:
1- share screenshot of collected data (as per acceptance criteria) at Mixpanel to be approved by @wp-media/product
2- While transient is set and not expired, with new pages with new GF, no new calculations/ data are sent to Mixpanel
3- confirm that if the transient is deleted manually, data will be recollected /resent

@wordpressfan
Copy link
Contributor

Do we need to mention this to the user in the following two views?

Screenshot from 2024-12-24 12-17-47

Screenshot from 2024-12-24 12-18-10

to tell the user what we track.
cc @wp-media/product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khadreal Khadreal Khadreal approved these changes

Assignees

@remyperona remyperona

Labels
type: sub-task Indicates the issue is a sub-task linked to an epics card
Projects
None yet
Milestone
3.18
Development

Successfully merging this pull request may close these issues.

3.18 - Data collection related to disk usage
4 participants
@remyperona @Mai-Saad @wordpressfan @Khadreal