You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently we register our translation domain with init action but with priority 10 here
So if we have a plugin that has any translatable strings from our domain before this priority, this will be a problem.
We had a dev escalation this week with this issue and we found that our settings dashboard is showing in English only in all cases.
Then we had a discussion with the team and agreed on changing this priority to be 0 or 1 to cover most of those cases.
To Reproduce
Steps to reproduce the behavior:
Use the following custom code:
add_action( 'init', function () {
error_log( esc_html__( 'WebP cache is disabled by filter.', 'rocket' ) );
}, 1 );
Change the dashboard language to be French
Visit our dashboard
Check debug.log, you will see the logged message in English
Expected behavior
We should load our translation domain early before any other plugins try to load any of our translatable strings.
Describe the bug
Currently we register our translation domain with init action but with priority 10 here
So if we have a plugin that has any translatable strings from our domain before this priority, this will be a problem.
We had a dev escalation this week with this issue and we found that our settings dashboard is showing in English only in all cases.
Then we had a discussion with the team and agreed on changing this priority to be 0 or 1 to cover most of those cases.
To Reproduce
Steps to reproduce the behavior:
French
debug.log
, you will see the logged message inEnglish
Expected behavior
We should load our translation domain early before any other plugins try to load any of our translatable strings.
Additional context
Slack Discussion: https://wp-media.slack.com/archives/C056ZJMHG0P/p1733743264603399
The text was updated successfully, but these errors were encountered: