Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self hosted google fonts are written to CNAME although CDN is disabled in certain scenario #7190

Open
Mai-Saad opened this issue Dec 16, 2024 · 0 comments
Open

Self hosted google fonts are written to CNAME although CDN is disabled in certain scenario #7190

Mai-Saad opened this issue Dec 16, 2024 · 0 comments
Labels
module: CDN module: google fonts module: remove unused css priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior

Comments

@Mai-Saad
Copy link
Contributor

Describe the bug
If CDN was served while host Google fonts is enabled before RUCSS was generated. When we disable CDN after RUCSS generation, the CDN will be served

To Reproduce
Steps to reproduce the behavior:

  1. Enable CDN and RUCSS
  2. Visit page with GF => CDN rewrites combined fonts (RUCSS still not generated)
  3. AFter RUCSS is generated, refresh the page => CDN rewrites local fonts in used CSS
  4. Disable CDN and revisit the page => still fonts preloaded and inside used CSS are written to CNAME

Expected behavior
While CDN is off, serve local fonts without CNAME

Additional context
Add any other context about the problem here.

  • If RUCSS was generated 1st before enable CDN, then enable/disable CDN will work correctly
  • If we clear used CSS after 4 and revisited the page after used CSS generation, it will work correctly
@Mai-Saad Mai-Saad added module: CDN module: google fonts module: remove unused css priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior labels Dec 16, 2024
@Mai-Saad Mai-Saad changed the title Self hosted google fonts are written to CDN although CDN is disabled in certain scenario Self hosted google fonts are written to CNAME although CDN is disabled in certain scenario Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: CDN module: google fonts module: remove unused css priority: low Issues that can wait severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mai-Saad