You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This behavior is also reproducible with .mp3 files and possibly other unsupported extensions.
To Reproduce
Steps to reproduce the behavior:
Enable the Preload Links module.
Add an <a> tag with an href pointing to an internal .mp4 file to a page or post.
Hover over the link.
Observe the 404 error in the browser console.
Expected behavior
Links pointing to unsupported file types (e.g., .mp4, .mp3) should be excluded from preloading, similar to how other file extensions are already excluded.
Screenshots
If applicable, provide screenshots showing the issue.
Desktop (please complete the following information):
OS: [e.g., Windows 10]
Browser: [e.g., Chrome 119]
Version: [e.g., 119.0.0]
Smartphone (please complete the following information):
Device: [e.g., iPhone 12]
OS: [e.g., iOS 17.1]
Browser: [e.g., Safari]
Version: [e.g., 17.1]
Additional context
The exclusion logic for file extensions in the Preload Links module can be found here:
[[Subscriber.php, line 135]https://github.com/wp-media/wp-rocket/blob/9acceaecbf5cf13da5502fd4ef3f1c95210a689c/inc/Engine/Preload/Links/Subscriber.php#L135)]
Describe the bug
When the Preload Links option is enabled, hovering over a link containing
.mp4
in thehref
causes a 404 error in the browser console.Example error:
Example HTML causing the issue:
This behavior is also reproducible with
.mp3
files and possibly other unsupported extensions.To Reproduce
Steps to reproduce the behavior:
<a>
tag with anhref
pointing to an internal.mp4
file to a page or post.Expected behavior
Links pointing to unsupported file types (e.g.,
.mp4
,.mp3
) should be excluded from preloading, similar to how other file extensions are already excluded.Screenshots
If applicable, provide screenshots showing the issue.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
[[Subscriber.php, line 135]https://github.com/wp-media/wp-rocket/blob/9acceaecbf5cf13da5502fd4ef3f1c95210a689c/inc/Engine/Preload/Links/Subscriber.php#L135)]
wp-rocket/inc/Engine/Preload/Links/Subscriber.php
Line 135 in 9acceae
.mp4
and other media files (e.g.,.mp3
) are not included in the list and should be considered for exclusion.The text was updated successfully, but these errors were encountered: