Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Play Youtube Video" aria-label should be translatable #7202

Open
audrasjb opened this issue Dec 24, 2024 · 0 comments · May be fixed by #7203
Open

"Play Youtube Video" aria-label should be translatable #7202

audrasjb opened this issue Dec 24, 2024 · 0 comments · May be fixed by #7203

Comments

@audrasjb
Copy link

Describe the bug
When using image remplacement for Youtube Iframes, the "Play Youtube Video" aria-label should be translatable. This is currently an issue with Accessibility Guidelines and as far as I know there is now way to properly override this string yet.

To Reproduce
Steps to reproduce the behavior:

  1. Activate lazyloading for video and activate thumbnails images for Youtube
  2. Switch your installation to another locale, like fr_FR (Français)
  3. Add a video on a post and confirm that the "Play Youtube Video" aria-label is not translated

Expected behavior
"Play Youtube Video" should be translated.

  • You have to replace the current implementation to a regular gettext string so it can be translated
  • Ideally, this string could be filterable via a hook (not mandatory)

Desktop (please complete the following information):

  • OS: All
  • Browser: All
  • Version: current

Smartphone (please complete the following information):
Same

Additional context
The issue lies here: https://github.com/wp-media/wp-rocket/blob/develop/inc/Dependencies/RocketLazyload/Assets.php#L283

Cheers Rocketeers!
Jb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant