Fix use cases for Subscription delete requests #842
+21
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chilliwiddit
requested review from
lasanthaS,
Krishanx92,
tharikaGitHub and
piyumaldk
as code owners
|
RakhithaRR
approved these changes
Dec 11, 2024
|
Shall we create git issue and point it to here? Thanks! |
|
Seems UI tests are failing. Can you please check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Notification for subscription deletion request was being shown as if an error occurred due to the use case not covering a 201 response for subscription approval workflows. In addition requesting a subscription deletion on the API page of the devportal would give no notification.
Fix
Notifications are now properly shown for each simple subscription delete and approval subscription delete
Fixes wso2/api-manager#3447