Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Schema-specific code in IFC4/IFC4x3 geometry code with schema agnostic interfaces #521

Open
andyward opened this issue Dec 16, 2024 · 0 comments

Comments

@andyward
Copy link
Member

Some of the latest IFC4.3 geometry code handling the new Curves types pre-dates IFC4.3 and made use of IFC4 specific implementations rather than the cross-schema interfaces. This was OK in IFC4 as Alignment was new in that schema. But it means some IFC4 GE logic will not work in IFC4.3. Equally using IFC4x3 concrete schemas will preclude its use on future IFC4.4 etc schemas

One example of IFC4 specific code that won't work for a IFC4.3 model in : XbimCompound::Init(IIfcTriangulatedFaceSet^ ...)

https://github.com/xBimTeam/XbimGeometry/blob/2707aeef3ce710314bc4860ea25324761e616e80/Xbim.Geometry.Engine/XbimCompound.cpp#L1210C4-L1216C1

A search of the codebase for "IFC4::" will reveal others - and unless they are just using the IFC4 Interfaces, the chances are this code will only support IFC4 and not IFC4.3 The same goes for searching for "IFC4x3::"

By and large we should be using the cross schema interfaces. We may need to consider introducing cross-schema interfaces for Measures given this is the comm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant