Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #58

Open
xarantolus opened this issue Jul 28, 2022 · 0 comments
Open

Modernize #58

xarantolus opened this issue Jul 28, 2022 · 0 comments

Comments

@xarantolus
Copy link
Owner

This software is

  1. quite old (especially regarding TypeScript/JS coding conventions)
  2. not well suited for larger collections (no search, no tagging etc.)
  3. barely updated (dependencies are out of date, some of them no longer supported etc)
    • I think this server doesn't work with newer versions of the website-scraper node module, so it's still on an older version

While it still works (I've had it running for 4+ years), it feels like it's time for an overhaul. The following could be good steps:

  1. Creating a better frontend (the code in browser.js works, but is a mess)
  2. Creating a docker (compose) configuration that just works to simplify installation
  3. Maybe switch to a database instead of just storing everything in a JSON file (not sure I'll do this, as it complicates setup etc.)
  4. Updating the downloader code to use newer website-scraper versions

2 & 4 should be possible without major rewrites, the others are somewhat more involved.

Maybe it also makes sense to rewrite the server in Go because I like it better, but I'm not sure if there's a good website-scraper-like module for Go. I actually tried writing something like that that started a chromium browser and used SingleFile to download pages, but it didn't work that well.

I'm not sure when (or if) I'll work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant