Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please stop changing the state keys #128

Open
rlaphoenix opened this issue Dec 22, 2021 · 1 comment
Open

Please stop changing the state keys #128

rlaphoenix opened this issue Dec 22, 2021 · 1 comment

Comments

@rlaphoenix
Copy link

As you can see here: https://github.com/rlaphoenix/VSGAN/blob/a81c177f00ee8cfb5bbc847c0da0ce2b5ad9d4ec/vsgan/archs/ESRGAN.py#L42

I need to manually do some key name replacing and regex checks to be able to support all models of all 3 types of RRDBNet archs you have done for: Original ESRGAN, Later ESRGAN (Near BasicSR), as well as Real-ESRGAN.

Please try not to change the state keys so much as it breaks compatibility with old models for testing and gives other devs a headache to try support them all. Thanks.

@lvchuandong
Copy link

lvchuandong commented Dec 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants