Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unit state for trigger conditionals for gaining new units #12660

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

SeventhM
Copy link
Collaborator

There's totally nothing suspicious here

Copy link
Owner

@yairm210 yairm210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what your comment is hinting at, this looks fine...?

@yairm210 yairm210 merged commit 7918123 into yairm210:master Dec 16, 2024
3 checks passed
@SeventhM
Copy link
Collaborator Author

SeventhM commented Dec 16, 2024

So this is fine, but there's actually some mad modder nonsense reason why I noticed this

Uniques such as Gain a free [building] [in this city] <upon founding a city> are known to work just fine despite kinda poor wording because founding a city actually provides the city information to the trigger. This was true even before we started assuming the city we wanted was the tile that we were working with

Turns out, despite warnings that it's not allowed, [This Unit] gains [amount] XP <upon gaining a [all] unit> currently functions. However, this leads to a weird scenario where <for [civFilter] units> doesn't work (this checks for unit information since it's actually a mapUnitFilter, but <for [civFilter] Civilizations> does work (we used civ.getMatchingUniques which by default includes the civ's state)

@SeventhM SeventhM deleted the new-unit-state branch December 16, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants