Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestions/bug reports about UI thread #4316

Closed
2 of 6 tasks
ajustsomebody opened this issue Jun 30, 2021 · 15 comments
Closed
2 of 6 tasks

suggestions/bug reports about UI thread #4316

ajustsomebody opened this issue Jun 30, 2021 · 15 comments
Labels

Comments

@ajustsomebody
Copy link
Contributor

ajustsomebody commented Jun 30, 2021

i'll list some of the ui problems that i have experienced while playing the game, also in order to not pollute the issues with minor ui problems (i think) you can report them here on comments ( if devs let (i haven't asked them before making this thread) )

referencing my old issue: #4315


  • the ui scale is too high on lower resolutions

Screenshot_20210630-114157_UnCiv.jpg

  • minimap is too small even on highest scaling on lower resolutions
    fixed: Minimap Slider UI #4634

  • show yields, show assigned tiles and show resource icons next to the minimap are bigger than the minimap on low resolutions
    fixed: Minimap Slider UI #4634 they scale with vertical heigt of the minimap

  • Problem with food + gold tiles, the gold icon completely covers the farm icon, as seen on the screenshot

Screenshot_20210630-134118_UnCiv.jpg

  • Turns until growth dont update properly. When you hit minus happiness just in this turn, the game assumes nothing happened and the city still shows the normal growth amount, but when you enter the city screen, or advance 1 turn, it comes back to normal, by normal i mean less growth cause of unhappiness being shown properly

  • When you get the double strategic resources bonus from autocracy, the resources in the top bar don't update unless you check them in resources in overview, i think something is wrong or doesn't automatically update when you pass a turn

@yairm210 yairm210 added AI UI and removed AI labels Jul 2, 2021
@ajustsomebody ajustsomebody changed the title UI problems thread suggestions/bug reports about UI thread Jul 21, 2021
@ajustsomebody
Copy link
Contributor Author

ajustsomebody commented Jul 21, 2021

Screenshot_20210721-103150_UnCiv.jpg

make some of the text continue resources have an emoticon/unicode character next to it

for instance as in the screenshot it should be 3😀 happiness instead of plain happiness

like if some city states provide production it should be 3 ⚙️ production

3🎵 culture etc. if there are no proper Unicode characters for this, if not hard to implement, i think the game should just use unciv coloured resource icons instead of emojis

edit: implemented in #4734 thanks to @SomeTroglodyte

@SomeTroglodyte
Copy link
Collaborator

No I implemented the capability for the stat symbols as part of text, not its use in all possible instances...

@ajustsomebody
Copy link
Contributor Author

Screenshot_20210804-095732_UnCiv.jpg

add a swap tiles button to below of worked by [cityname]

@SomeTroglodyte
Copy link
Collaborator

That button has been taken out on purpose a long time ago to reduce exploitability. Look it up, it's all here in the history.

@xlenstra
Copy link
Collaborator

xlenstra commented Aug 4, 2021

That button has been taken out on purpose a long time ago to reduce exploitability. Look it up, it's all here in the history.

If my memory serves well, that was for swapping a tile between different cities, which is indeed exploitable.
What is requested here, is a button that will allow you to start working a tile currently worked by another city, which should not be exploitable.

@ajustsomebody
Copy link
Contributor Author

ajustsomebody commented Aug 4, 2021

That button has been taken out on purpose a long time ago to reduce exploitability. Look it up, it's all here in the history.
@xlenstra @yairm210
If my memory serves well, that was for swapping a tile between different cities, which is indeed exploitable.
What is requested here, is a button that will allow you to start working a tile currently worked by another city, which should not be exploitable.

i mean yes. i meant that, what will happen to the other cities population when that hsppens though, also what is exploitable about tile swapping? it is in civ 5 if im not wrong

@xlenstra
Copy link
Collaborator

xlenstra commented Aug 4, 2021

Swapping tiles between cities is not in civ 5, I used to think that too but after testing it didn't appear to be (see among other things discussion in #663).
On what is exploitable about it:

  • If you almost lose a city due to it being captured by an enemy, quickly move all possible tiles to other cities
  • We calculate the amount of culture necessary for border expansion using the current amount of tiles in the city. While we could changes this to the amount of tiles expanded so far, we have not, so adding tile swapping without fixing this will allow you to swap all tiles away from a city, let it expand immediately due to the culture cost being lowered, and give the tiles back.

All these problems and more don't happen when the tiles stay with the city they are of and only allow them to be worked by other cities, so your suggestion would work fine in that regard. The population that used to be working that tile should simply be unassigned for now, but when we implement the automatic reassignment of worked tiles, it should just be reassigned immediately.

@ajustsomebody
Copy link
Contributor Author

ajustsomebody commented Aug 4, 2021

Swapping tiles between cities is not in civ 5, I used to think that too but after testing it didn't appear to be (see among other things discussion in #663).
On what is exploitable about it:

  • If you almost lose a city due to it being captured by an enemy, quickly move all possible tiles to other cities
  • just make the tiles that have been swapped x*gamepace turns before the war broke out disappear from the control of that city
  • We calculate the amount of culture necessary for border expansion using the current amount of tiles in the city. While we could changes this to the amount of tiles expanded so far, we have not, so adding tile swapping without fixing this will allow you to swap all tiles away from a city, let it expand immediately due to the culture cost being lowered, and give the tiles back.
  • Only the tiles that it has originally expanded onto should be calculated even if they have been swapped and those havent been stolen by citadels. say if a city has 11 tiles and it swaps 10 of it the culture should be calculated for 11-stolenterritory tiles and it should normally rise in that city that has taken it

so above are my proposals to fix it

, but when we implement the automatic reassignment of worked tiles, it should just be reassigned immediately.

+this absolutely is required and i will be thankful to one that implements it, this might not be a game breaking bug but it is enough to lower the quality of game highly and make some of the improvements useless unless the player notices it and reassigns the population to a net positive tile (dont know what would happen if it had to change to another yield one)

@SomeTroglodyte
Copy link
Collaborator

currently worked by another city, which should not be exploitable.

Ah, pure convenience, instead of having to go into that other city and deselecting the tile there - yea I know, but I wish for that feature so rarely - nah, music diversity first please

@ajustsomebody
Copy link
Contributor Author

Add an option to undo a friendship agreement treaty, it is really frusturating when you accidentally declare friendship with a civ that you want to declare war on

@foolishgrunt
Copy link

foolishgrunt commented Nov 3, 2021

Nation logo overlaps gold display. Seems like there should be a way to detect if there will be a conflict and shift the whole top pane to the right. Perhaps make the top pane scrollable for smaller screens, if it's not already. (My Pixel 3a has a 1080 x 2220 and I have not tested on other devices.)

Screenshot_20211102-191229_UnCiv

@AdityaMH
Copy link
Contributor

AdityaMH commented Apr 8, 2022

  • Problem with food + gold tiles, the gold icon completely covers the farm icon, as seen on the screenshot

Screenshot_20210630-134118_UnCiv.jpg

Maybe can replace to dot color only or make them smaller.

#5856

Copy link

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@SeventhM
Copy link
Collaborator

The UI has changed considerably since. Can someone confirm this is still worth keeping open?

@github-actions github-actions bot removed the Stale label Mar 17, 2024
@yairm210
Copy link
Owner

The specific cases outlined in this issue are dealt with, we can deal with others on an individual basis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants