You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 26, 2018. It is now read-only.
Then you can link to the docs for the cartesian chart mixin and Axes, and remove all stuff concerning them that is repeated for every chart - incompletely and soon inconsistently, because it needs to be maintained at many places.
Proposal: cartesianChartProps and axisProps would actually better be passed as a single object prop, e.g.
so that prop names remain consistent across components (no prefix), for maintainability (1 prop to transfer), and to simplify the docs (1 prop to document for charts, then link to the Axes docs).
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The docs should indicate that props are passed as
Then you can link to the docs for the cartesian chart mixin and Axes, and remove all stuff concerning them that is repeated for every chart - incompletely and soon inconsistently, because it needs to be maintained at many places.
Proposal:
cartesianChartProps
andaxisProps
would actually better be passed as a single object prop, e.g.so that prop names remain consistent across components (no prefix), for maintainability (1 prop to transfer), and to simplify the docs (1 prop to document for charts, then link to the Axes docs).
The text was updated successfully, but these errors were encountered: