Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README by quoting git in require(git):setup() #41

Closed
bnmadden9 opened this issue Dec 22, 2024 · 1 comment
Closed

Fix README by quoting git in require(git):setup() #41

bnmadden9 opened this issue Dec 22, 2024 · 1 comment
Labels
invalid This doesn't seem right

Comments

@bnmadden9
Copy link

What system are you running Yazi on?

Linux Wayland

What terminal are you running Yazi in?

kitty 0.35.2

yazi --debug output

Yazi
    Version: 0.4.1 (VERGEN_IDEMPOTENT_OUTPUT 2024-12-11)
    Debug  : false
    Triple : x86_64-unknown-linux-gnu (linux-x86_64)
    Rustc  : 1.83.0 (90b35a62 2024-11-26)

Ya
    Version: 0.4.1 (VERGEN_IDEMPOTENT_OUTPUT 2024-12-11)

Emulator
    Brand.from_env      : Some(Kitty)
    Emulator.detect     : Emulator { kind: Left(Kitty), light: false, cell_size: Some((10, 22)) }
    Emulator.detect_full: Ok(Emulator { kind: Left(Kitty), light: false, cell_size: Some((10, 22)) })

Adapter
    Adapter.matches: Kgp

Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-0")
    DISPLAY                    : Some(":1")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

NVIM
    NVIM          : false
    Neovim version: 0.9.5

Variables
    SHELL           : Some("/bin/zsh")
    EDITOR          : Some("nvim")
    VISUAL          : None
    YAZI_FILE_ONE   : None
    YAZI_CONFIG_HOME: None
    YAZI_ZOXIDE_OPTS: None
    FZF_DEFAULT_OPTS: None

Text Opener
    default     : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-create: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block-rename: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : 0
    tmux version       : No such file or directory (os error 2)
    tmux build flags   : enable-sixel=Unknown
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file          : 5.45
    ueberzugpp    : No such file or directory (os error 2)
    ffmpeg/ffprobe: 7.0.2-3 / 7.0.2-3
    pdftoppm      : 24.08.0
    magick        : No such file or directory (os error 2)
    fzf           : 0.46.1
    fd/fdfind     : No such file or directory (os error 2) / No such file or directory (os error 2)
    rg            : 14.1.0
    chafa         : No such file or directory (os error 2)
    zoxide        : 0.9.4
    7z/7zz        : 24.08 / No such file or directory (os error 2)
    jq            : 1.7

Clipboard
    wl-copy/paste: 2.2.1 / 2.2.1
    xclip        : 0.13
    xsel         : No such file or directory (os error 2)

Describe the bug

Not sure if this is just on my system, but update readme with quotes around git, so it says:

require("git"):setup()

What is in the readme causes this error:
Error: Lua runtime failed

Caused by:
bad argument #1: error converting Lua nil to string (expected string or number)
stack traceback:
[C]: in function 'require'
[string "init.lua"]:34: in main chunk

Minimal reproducer

Add this plugin, and follow the steps in the readme. This caused the error on my system.

Anything else?

No response

@bnmadden9 bnmadden9 added the bug Something isn't working label Dec 22, 2024
@sxyazi
Copy link
Member

sxyazi commented Dec 22, 2024

README is quoted already:

require("git"):setup()

Closing as nothing can be fixed

@sxyazi sxyazi closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2024
@sxyazi sxyazi added invalid This doesn't seem right and removed bug Something isn't working labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants