Skip to content
This repository has been archived by the owner on Mar 26, 2018. It is now read-only.

Upgrade grunt-jscs #1333

Open
jordanambra opened this issue Jun 16, 2016 · 1 comment
Open

Upgrade grunt-jscs #1333

jordanambra opened this issue Jun 16, 2016 · 1 comment

Comments

@jordanambra
Copy link

jordanambra commented Jun 16, 2016

Hi, this generator is currently using a reasonably outdated version of grunt-jscs (^1.8.0), which has a version lock of the underlying jscs library at ~1.13.0. grunt-jscs is currently at 3.0.0 and jscs is at 3.0.4 on npm.

Can you please update the package.json template so that the newer versions of grunt-jscs is in? In particular, jscs has a feature as of 1.6.0 where you can do an inline ignore which isn't supported in 1.13.0.

Additionally, the Gruntfile.js needs to have the jscs.options.verbose option removed, because it's default as of 3.0.

Thanks!

@erikyuzwa
Copy link

looks like it might be covered by PR #1376 - minus the jscs.options.verbose modifications.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants