Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with deck feature #4

Open
Ejeffers1239 opened this issue Sep 18, 2022 · 5 comments
Open

Issue with deck feature #4

Ejeffers1239 opened this issue Sep 18, 2022 · 5 comments

Comments

@Ejeffers1239
Copy link

Ejeffers1239 commented Sep 18, 2022

I'm attempting to use your yrp parser for a statistics project, but I'm at a roadblock as it seems that the replay is initialized with an empty decks field. Attempting to lead the replay by buffer gives a "failed to decompress replay data" exception instead. I've included debugger output in hopes that this can be troubleshooted.
image

Thanks for your time and the maintenance of this cool parser,
-Ejeffers

@async3619
Copy link
Member

First of all, can you let me know which replay file type you trying to parse? I wasn't implemented parsing feature of YRPX (which used by EDOPro client) and this parser works well just for YRP replay type (which used by YGOPro client) at the moment.

@Ejeffers1239
Copy link
Author

Ah, that would do it, my data is mixed but mostly YRPX at the moment, I'll try again and maybe see if I can find a way to convert the replay types. I'm glad you were able to respond as well, it happens so frequently that this sort of small project ends up totally abandoned.

@async3619
Copy link
Member

@Ejeffers1239 don't worry about it. I'll update this project as soon as possible.

@monyarm
Copy link

monyarm commented Oct 23, 2022

Till you do add YRPX, could you maybe not falsely advertise that yrp can handle YRPX?

@async3619
Copy link
Member

falsely advertise

Sorry for that @monyarm, but I had set my project's goal to support both YRP/YRPX when I started work on this project. so I've specified that this parser would support to parse YRP/YRPX format. anyway if you want to use a parser that supports parsing YRPX, how about make your own module or create PR about implementing YRPX parsing feature?

@async3619 async3619 pinned this issue Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants