Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash parameter to UrlGenerator methods for generate URL #252

Open
vjik opened this issue Nov 21, 2024 · 5 comments
Open

Add hash parameter to UrlGenerator methods for generate URL #252

vjik opened this issue Nov 21, 2024 · 5 comments
Labels
severity:BC breaking Breaks backwards compatibility status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement

Comments

@vjik
Copy link
Member

vjik commented Nov 21, 2024

No description provided.

@xepozz
Copy link
Member

xepozz commented Nov 21, 2024

What is a hash? Query parameters?

@vjik
Copy link
Member Author

vjik commented Nov 21, 2024

What is a hash? Query parameters?

No. String after #. For example:

https://example.com/action?param=value#hello

"hello" is hash

@samdark samdark added type:enhancement Enhancement status:ready for adoption Feel free to implement this issue. labels Nov 22, 2024
@samdark
Copy link
Member

samdark commented Nov 22, 2024

I think we should name it #

@vjik
Copy link
Member Author

vjik commented Nov 23, 2024

In RFC 3896 this part of URL is called "fragment identifier" or just "fragment". But "hash" is a popular term for call it. For example, property window.location.hash in JS.

@samdark
Copy link
Member

samdark commented Nov 23, 2024

I'd leave it as "hash". It's a common name.

@vjik vjik added the severity:BC breaking Breaks backwards compatibility label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity:BC breaking Breaks backwards compatibility status:ready for adoption Feel free to implement this issue. type:enhancement Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants