Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Consider enabling webform ui module by default #2339

Open
ddrozdik opened this issue Dec 17, 2020 · 5 comments
Open

Consider enabling webform ui module by default #2339

ddrozdik opened this issue Dec 17, 2020 · 5 comments
Labels
good first issue Issue for anybody to start with Open Y Level: Novice Low effort issue Severity: Normal Not critical, but still important. Selected for development. Type: Enhancement Change request. New functionality.

Comments

@ddrozdik
Copy link
Contributor

In the past module, webform_ui was enabled by default for all Open Y installation types

'webform_ui',

However, now it is disabled by default. It can be enabled easily by adding into the list of dependencies for the Webform package https://github.com/ymcatwincities/openy/blob/8.x-2.x/openy.packages.yml#L297

We checked our live Open Y websites and noticed this module enabled on all of them. Some associations use it frequently.

We recommend enabling it by default.

@podarok podarok added good first issue Issue for anybody to start with Open Y Level: Novice Low effort issue Severity: Normal Not critical, but still important. Selected for development. Type: Enhancement Change request. New functionality. labels Dec 17, 2020
@podarok
Copy link
Contributor

podarok commented Dec 17, 2020

UI modules in Drupal - modules as candidates for keeping disabled due to performance reasons.
We all know how tough is cache clear - almost 0 sites could clear cache from Admin UI, almost 0 sites could enable a module from Admin UI and router(menu) contributes to this majority of the weight.
UI modules are tough in terms of performance for admin interface.

I would keep them disabled and keep recommending to have it disabled in production. But if the community decided to enable it by default - we can make it. @sarah-halby

@ddrozdik
Copy link
Contributor Author

@podarok, @sarah-halby Webform UI module is the only way to add anything to existing webforms or create a new one via the admin interface. All YMCA associations who work with Five Jars frequently create webforms on their own and they need access to this part of the admin interface.

Until then we handle this as customization.

@sarah-halby
Copy link
Collaborator

@sarah-halby to check with ImageX about their clients to determine how they use with their clients. This is a feature request. Would need to provide documentation and upgrade path.

@ddrozdik
Copy link
Contributor Author

@sarah-halby it may look like a regression because this module was enabled by default at some point in the past, but then for some reason, it became disabled.

@podarok
Copy link
Contributor

podarok commented Dec 22, 2020

@ddrozdik webform_ui was introduced by webform community. Before it was a part of webform core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Issue for anybody to start with Open Y Level: Novice Low effort issue Severity: Normal Not critical, but still important. Selected for development. Type: Enhancement Change request. New functionality.
Projects
None yet
Development

No branches or pull requests

3 participants