Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Carnation: Support mega menu icons #2564

Open
froboy opened this issue Sep 27, 2021 · 8 comments
Open

Carnation: Support mega menu icons #2564

froboy opened this issue Sep 27, 2021 · 8 comments
Labels
Status: Under discussion There is discussion in progress. More information to be provided soon UX To discuss/approve with UX director

Comments

@froboy
Copy link
Collaborator

froboy commented Sep 27, 2021

Icons for second-level menu items are supported in Rose, but not Carnation. Lily doesn't use mega-menus so its implementation might not make sense.

Open_Y___Drush_Site-Install_and_Open_Y___Drush_Site-Install_—_Private_Browsing
e

A few sites like https://www.ymcamissoula.org/, https://www.akronymca.org/ have implemented this, but all with custom CSS. We should be able to use the Icon image field on menu items to write the CSS using simple_menu_icons.

// Section icons are set via UI and simple_menu_icons module.

@sarah-halby
Copy link
Collaborator

@shelleygoetz can you open a ticket in the maintain backlog for this issue?

@podarok
Copy link
Contributor

podarok commented Sep 29, 2021

I guess this should go via Ben's review @sarah-halby
Carnation was created without icons for a reason. Let's ensure we have a good UX when enabling them in themes, which weren't created with them

@shelleygoetz
Copy link
Collaborator

@sarah-halby Let me know if you want me to create a Jira ticket for this or hold based on @podarok's response above.

@sarah-halby
Copy link
Collaborator

@shelleygoetz let's hold on this for now. We'll need Ben's time for this and his bandwidth is strapped at the moment.

@shelleygoetz shelleygoetz added Status: Under discussion There is discussion in progress. More information to be provided soon UX To discuss/approve with UX director labels Oct 25, 2021
@llamarama
Copy link

Ben here. Thanks for the consideration! Since this isn't my theme, my suggestion would be to ask the creator's opinion (if possible) before making any decisions.

In this case, Image X created the Carnation theme. And with credit to them, we should ask them what they think. If they're all for it (or not against it), then it becomes an addition with considering. Then, at that point, we should ask if and how they might like to see it implemented.

@sarah-halby
Copy link
Collaborator

Thanks, @llamarama - @KylieAldridge suggested that we do implement this based on their client experience. Kylie, what would be your suggestion for a client to backport this from? @shelleygoetz please add a Jira ticket for the maintain board so we can get this backported from the IMX team.

@shelleygoetz
Copy link
Collaborator

Jira ticket created here: https://openy.atlassian.net/browse/MAINTAIN-186

@froboy
Copy link
Collaborator Author

froboy commented Feb 22, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Under discussion There is discussion in progress. More information to be provided soon UX To discuss/approve with UX director
Projects
None yet
Development

No branches or pull requests

5 participants