Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill doesn't work for IE 11 #12

Closed
Tokimon opened this issue May 10, 2016 · 1 comment
Closed

Polyfill doesn't work for IE 11 #12

Tokimon opened this issue May 10, 2016 · 1 comment

Comments

@Tokimon
Copy link

Tokimon commented May 10, 2016

Hi.

Thanks for a great polyfill, but unfortunately it doesn't fix the IE 11 classList.add problem.
The first if statement:

if(document.createElementNS && !("classList" in document.createElementNS("http://www.w3.org/2000/svg","g"))) {

Makes it so it never reaches the second statement where you correct the missing functionality of the 'add', 'remove' and 'toggle' methods.
Normally you should think that this doesn't matter as the first part should add similar functionality, but apparently this isn't the case.

I have tried running the script into the IE 11 browser and when I try to set the class names of document.body, it only sets the first argument.

@Tokimon
Copy link
Author

Tokimon commented May 10, 2016

Ok I see that this issue has already been raised here:
eligrey/classList.js#44
Sorry for the inconvenience.

@Tokimon Tokimon closed this as completed May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant