Skip to content

Latest commit

 

History

History
102 lines (70 loc) · 5.08 KB

CONTRIBUTING.md

File metadata and controls

102 lines (70 loc) · 5.08 KB
Raw

How to contribute to tsai: pull requests made easy

Making your first pull request to tsai

First, thank you very much for wanting to help!

To contribute to tsai, you will need to create a pull request, also known as a PR. When you submit it he tsai team get a notification and, after checking if the changes look good, we'll "merge" it (meaning your changes will be automatically added to the repository).

It's very easy to create a PR to tsai.

Key points:

  • In this guide, we assume that you are using Linux or Mac and that you already have Anaconda or Miniconda set up. On Windows, use Ubuntu on WSL.

  • We will be using GitHub's official CLI gh, which makes things faster and easier than doing things through the website.

  • tsai has been built with nbdev. nbdev is a library that allows you to develop a Python library in Jupyter Notebooks, putting all your code, testing, and documentation in one place.

  • We will also show you how to create a separate conda environment with all required packages. This is optional, although highly recommended.

  • If you are unfamiliar with the fastai / tsai code style, be sure to read [this] (https://docs.fast.ai/dev/style.html) first. (Note that, like fastai, we do not follow PEP8, instead we follow a coding style designed specifically for numeric and interactive programming.)

One-time only setup:

All steps in this section need to be done only the first time you set up the environment where you will develop tsai.

Steps:

  1. Set up gh. If you don't have gh (GitHub CLI) yet, you can install it by following these instructions. To authenticate with your GitHub account run:

    gh auth login

    and follow the instructions.

  2. Create and activate a new conda environment. This step is optional, but recommended. You will need to choose a name for the environment and a version of Python (I chose tsai_dev and Python 3.7, but you can choose others).

    conda create -n tsai_dev python=3.7  # python=3.7 will be used in testing, so it's better if you use it in your dev env as well to avoid issues when submitting PRs.
conda activate tsai_dev

  3. Set up tsai. We'll use an editable install. Navigate to the folder where you want to install the tsai repo in your local machine and:

    git clone https://github.com/timeseriesAI/tsai
pip install -e "tsai[dev]"

    The last step will install all packages required to run tsai.

  4. Set up git hooks. This step is required by nbdev. Run:

    nbdev_install_hooks

    inside the same tsai repo folder. Git hooks clean up the notebooks to remove the extraneous stuff stored in the notebooks. In this way you avoid unnecessary merge conflicts.

Great! You are now ready to start working on your first tsai PR.

Creating a PR:

If you have already set up your environment, you can proceed with the following steps.

Steps:

  1. Navigate to the tsai repo folder and activate your tsai_dev environment:

    conda activate tsai_dev

  2. Use git pull origin main to ensure you have the most recent version of the repo.

  3. Navigate to the nbs folder in the local repo and open the required Jupyter Notebook you wish to modify. If you are unsure which notebook it is, you can find it at the top of the script you wish to modify. Make whatever changes you want to make in the notebooks (ie., update feature, add new feature, add tests, add documentation, etc.).

    • Any new code you create needs to be in a cell with #export at the top.
    • You can write Markdown text as you would normally do to document any new functionality.
    • Remember that nbdev creates all scripts, tests and documentation from the notebooks. That's why it's important that you explain how the code works. You should also add tests. Tests will ensure that the new functionality keeps working in the future, when new changes are made.
    • When finished, restart the kernel and re-run the whole notebook. Make sure everything runs smoothly until the end. This will also automatically save the notebook. If you see this at the bottom of the notebook "Correct conversion! 😃", it means everything went well and you can close the notebook. You are now ready to create your PR.

  4. Review the files that have been changed. You can do that with:

    git status

    Whenever you make a change in a notebook, you should see at least see changes in its .ipynb and .py corresponding files.

  5. Commit your changes:

    git commit -am "add a message here"

  6. Create a fork and push your changes there:

    gh repo fork
git push origin master

  7. You are now ready to create a PR:

    gh pr create

    and add the required information (Title). You can skip the body (we'll do it later in GitHub). Choose Submit in What's next? That will create the PR.

  8. Click on the link that will show up. That'll take you to the PR in GitHub. You can now edit the description to provide details on the PR, and click "Update comment". That's it. You'll soon receive a response from a tsai team member.